Complex FOR Statement

[mharper90]

I can't seem to get this code to work. Any ideas? This is my first time using a FOR statement in VBA.

Sub Sort()

Dim x       As Long
Dim ws   As Worksheet

For x = 1 To 8

Set ws = ThisWorkbook.Sheets("P" & x & " Figure 2-2")

Lr = ws.Range("A" & Rows.Count).End(xlUp).Row

If Lr > 3 Then
     ws.Range("A3:O" & Lr).Sort Key1:=[C3], Order1:=xlAscending
     ws.Range("A3:O" & Lr).Sort Key1:=[A3], Order1:=xlAscending
End If

Next x

End Sub

 

[Michael M]

What part of it doesn't work ??
Have you stepped through line by line using F8 to see where it fails ??

 

[6StringJazzer]

It would help if you described what you want the code to do. What is the difference between what it does and what you want it to do?

What your code actually does is cycle through 8 different worksheets, setting sort keys (but not actually performing a sort). The worksheets are named

P1 Figure 2-2
P2 Figure 2-2
P3 Figure 2-2
etc.

The code that sets the sort key won't work because you are setting Key1 using [brackets] which will refer to a range in the active sheet. You need this:

     ws.Range("A3:O" & Lr).Sort Key1:=ws.Range("C3"), Order1:=xlAscending

However, I am not at all sure that is the only problem.