Compile Error - Versions

[Sven62]

Can anyone tell what the prob might be. Getting compile error on start up. Used to work fine. Then they upgraded to Windows 10. I suspect a 32/64 bit confliction. Any suggestions? Thanks

Option ExplicitPrivate Declare Function ShowWindow _
Lib "user32" _
(ByVal hwnd As Long, _
ByVal nCmdShow As Long) _
As Long

 

[Sven62]

I think I found the answer. Need to add "PtrSafe" in between "Declare" and "Function". Also need to change any "Long" or "LongLong" to "LongPtr"

 

[theBardd]

Only the pointers not all longs, and best to cater for 32 and 64-bit with conditional compilation

#If VBA7 Then
    Private Declare PtrSafe Function ShowWindow Lib "USER32" _
        (ByVal hwnd As LongPtr, ByVal nCmdShow As Long) As Long
[URL=https://www.mrexcel.com/forum/usertag.php?do=list&action=hash&hash=Else]#Else[/URL] 
    Private Declare Function ShowWindow Lib "USER32" _
        (ByVal hwnd As Long, ByVal nCmdShow As Long) As Long
[URL=https://www.mrexcel.com/forum/usertag.php?do=list&action=hash&hash=End]#End[/URL]  If

 

[Sven62]

Hey thanks! I got this from Microsoft site

"Writing code that works on both 32-bit and 64-bit Office

To write code that can port between both 32-bit and 64-bit versions of Office, you only need to use the new LongPtr type alias instead of Long or LongLong for all pointers and handle values. The LongPtr type alias will resolve to the correct Long or LongLong data type depending on which version of Office is running."

And that change did not cause any unusual performance on my 64 bit system. I also made the PtrSafe change.

 

[Sven62]

Only the pointers not all longs

YUP - You are correct! I had changed all the LONGs and now getting compile errors related to that. I changed them back. Works fine. Thank you!!

 

[Sven62]

And that change did not cause any unusual performance on my 64 bit system.

Yeah I was wrong about that! See above