Combining Code

fdfordham

New Member
Joined
Aug 12, 2021
Messages
6
Office Version
  1. 365
Platform
  1. Windows
Below I have 2 sets of VBA code for hiding columns and hiding rows. Both work great, but only the hide column portion works when added together. What am I doing wrong? Thanks for the help!


Private Sub Worksheet_Change(ByVal Target As Range)

Dim cCell As Range
If Target.Address <> Range("C64").Address Then Exit Sub
Application.ScreenUpdating = False
For Each cCell In Range("K1:AZ1")
cCell.EntireColumn.Hidden = (cCell.Value < Target.Value)
Next
Application.ScreenUpdating = True

Dim rCell As Range
If Target.Address <> Range("C65").Address Then Exit Sub
Application.ScreenUpdating = False
For Each rCell In Range("I1:I57")
rCell.EntireRow.Hidden = (rCell.Value = Target.Value)
Next
Application.ScreenUpdating = True


End Sub
 

Excel Facts

Create a chart in one keystroke
Select the data and press Alt+F1 to insert a default chart. You can change the default chart to any chart type
you're using Exit Sub after the first condition

Try like below

VBA Code:
Private Sub Worksheet_Change(ByVal Target As Range)

    Dim cCell As Range
    Dim rCell As Range
    
    Application.ScreenUpdating = False
    
    For Each cCell In Range("K1:AZ1")
        If Target.Address = Range("C64").Address Then
            cCell.EntireColumn.Hidden = (cCell.Value < Target.Value)
        End If
    Next
    
    For Each rCell In Range("I1:I57")
        If Target.Address = Range("C65").Address Then
            rCell.EntireRow.Hidden = (rCell.Value = Target.Value)
        End If
    Next
    
    Application.ScreenUpdating = True

End Sub
 
Upvote 0
Try this.

VBA Code:
Private Sub Worksheet_Change(ByVal Target As Range)
 Dim cCell As Range
  Application.ScreenUpdating = False
  If Target.Address = "$C$64" Then
   For Each cCell In Range("K1:AZ1")
    cCell.EntireColumn.Hidden = cCell.Value < Target.Value
   Next
  ElseIf Target.Address = "$C$65" Then
   For Each cCell In Range("I1:I57")
    cCell.EntireRow.Hidden = cCell.Value = Target.Value
   Next
  End If
End Sub
 
Upvote 0
you're using Exit Sub after the first condition

Try like below

VBA Code:
Private Sub Worksheet_Change(ByVal Target As Range)

    Dim cCell As Range
    Dim rCell As Range
   
    Application.ScreenUpdating = False
   
    For Each cCell In Range("K1:AZ1")
        If Target.Address = Range("C64").Address Then
            cCell.EntireColumn.Hidden = (cCell.Value < Target.Value)
        End If
    Next
   
    For Each rCell In Range("I1:I57")
        If Target.Address = Range("C65").Address Then
            rCell.EntireRow.Hidden = (rCell.Value = Target.Value)
        End If
    Next
   
    Application.ScreenUpdating = True

End Sub
Works great. Thank you!
 
Upvote 0

Forum statistics

Threads
1,223,896
Messages
6,175,265
Members
452,627
Latest member
KitkatToby

We've detected that you are using an adblocker.

We have a great community of people providing Excel help here, but the hosting costs are enormous. You can help keep this site running by allowing ads on MrExcel.com.
Allow Ads at MrExcel

Which adblocker are you using?

Disable AdBlock

Follow these easy steps to disable AdBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the icon in the browser’s toolbar.
2)Click on the "Pause on this site" option.
Go back

Disable AdBlock Plus

Follow these easy steps to disable AdBlock Plus

1)Click on the icon in the browser’s toolbar.
2)Click on the toggle to disable it for "mrexcel.com".
Go back

Disable uBlock Origin

Follow these easy steps to disable uBlock Origin

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back

Disable uBlock

Follow these easy steps to disable uBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back
Back
Top