Code to automate CMD steps in VBA

[JackDanIce]

Hi,

Manually, I can do:

Windows, launch CMD.exe (Start->Run cmd Enter)
[In DOS prompt] "cd /d D:\Serious\Work\Other People\Al\DataRead"
[DOS] "type *.csv > x.txt"

This creates concatenated text file of all csv files in folder.

If I run below VBA, I receive error: "The system cannot find the path specified."

Sub testme()

Dim s   As String: s = Range("Folder").Offset(, 1).Text

'1: vbNormalFocus
Call Shell("cmd.exe /k cd /d " & s, 1")

End Sub

Where Range("Folder").text contains a folder path ending with ""

Please someone help with code to automate these steps?

Ultimately, it will be used to concatenate CSV files in a DropBox folder, then write x.txt to Excel and analyse results.

TIA,
JackDanIce

 

[mole999]

you have three parenthesis in the call, they have to be paired?

 

[JackDanIce]

Apologies, meant:

Sub testme()

Dim s   As String: s = Range("Folder").Offset(, 1).Text

s = "cmd.exe /k cd /d " & s

'1: vbNormalFocus
Call Shell(s & ", 1")

End Sub

 

[Tetra201]

... I receive error: "The system cannot find the path specified."...

Try

...
Call Shell(s, 1) 'Not Call Shell(s [COLOR=#ff0000]& ", 1"[/COLOR])
...

 

[JackDanIce]

Hi Tetra201, thank you that works and changes the directory. Final part, how do I add "*.csv > x.txt" ?

Trying this errors "The directory name is invalid"

Sub testme()

Dim s   As String: s = Range("Folder").Offset(, 1).Text
s = "cmd.exe /k cd /d " & s & "*.csv > x.txt"

'1: vbNormalFocus
Call Shell(s, 1)

End Sub

I'm trying to avoid using a .bat file or creating a temporary one to run 2 commands and then delete it, any suggestions please?

 

[JackDanIce]

Got it:

Sub testme()

Dim s   As String: s = ThisWorkbook.Sheets("Main").Range("Folder").Offset(, 1).Text
s = "cmd.exe /k cd /d " & s & "& type *.csv > x.txt"

'1: vbNormalFocus
Call Shell(s, 1)

End Sub

Part in red was missing, thank you both @mole99 and @Tetra201!

 

[Tetra201]

Glad to have helped.

 

[JackDanIce]

One more related question - how can I tell when the output file x.txt is complete?

I'm using an arbitary 5 second wait here but any other suggestions:

Private Sub Create_txt_File(ByRef strFilePath As String)

    Dim s   As String
    s = "cmd.exe /k cd /d " & strFilePath & "& type *.csv > x.txt"
    
    '1: vbNormalFocus
    Shell s, 1
    
    Do
        Application.Wait Now + TimeSerial(0, 0, 5)
    Loop Until Len(Dir(strFilePath & "x.txt"))
    
End Sub

This isn't ideal because it tests only if the file exists not whether the operation is complete.

Later, I'll add code to kill the cmd window and x.txt file.

 

[Tetra201]

Maybe

Private Sub Create_txt_File(ByRef strFilePath As String)

    Dim s   As String
    s = "cmd.exe /k cd /d " & strFilePath & "& type *.csv > x.txt [COLOR=#ff0000]& echo 0 > Done.txt[/COLOR]"
    
    '1: vbNormalFocus
    Shell s, 1
    
    Do
        Application.Wait Now + TimeSerial(0, 0, 5)
    Loop Until Len(Dir(strFilePath & "[COLOR=#ff0000]Done.txt[/COLOR]"))
    
End Sub

 

[JackDanIce]

Great suggestion, thank you