code not working at the end if/with

[dannyok90]

The last part of this code is not working, its saying end with without with and I cant workout why? any ideas guys? happy new year!

Public Sub SaveAsC3()
    Dim ThisFile As String, DoF As String
    ThisFile = Range("C3").Value
    DoF = Range("V2").Value
    fName = "T:\V-Task\V0000+\200+\V0297\Shared\PSR Submissions\" & ThisFile & " " & "PSR" & " " & DoF
    ActiveWorkbook.Save
    On Error GoTo err
    Application.DisplayAlerts = False
    If (MsgBox("Are you sure you want to submit this PSR?", vbYesNo, "Decision")) = vbYes Then
        With ActiveWorkbook
            .SaveAs Filename:=fName, FileFormat:=xlOpenXMLWorkbookMacroEnabled
            Application.ExecuteExcel4Macro "show.toolbar(""Ribbon"",TRUE)"
            ActiveWindow.DisplayWorkbookTabs = True
            Application.DisplayAlerts = False
            If Workbooks.Count < 2 Then
            Application.Quit
 Else
 ThisWorkbook.Close
        End With
    End If
err:
    Application.DisplayAlerts = False
End Sub

 

[JazzSP8]

Looks like you're missing an End If

            If Workbooks.Count < 2 Then
                Application.Quit
            Else
                ThisWorkbook.Close
            End If

HTH

 

[dannyok90]

And its as simple as that!! :D haha thanks JazzSP8!

 

[JazzSP8]

Nah bother - It can throw you sometimes "End With without With" when it really means "If without End If", used to catch me out when I first started out. Always best to check for both when it gives this kind of error

 

[dannyok90]

yeah I was switching the end if and the end with round and still getting nothing, thanks for the education my friend!