Code ignores my If code statement

[ipbr21054]

I am trying to check if a checkbox is true & if so do something.

My invoice is printed & i see the message INVOICE HAS NOW BEEN SAVED.
It is now i wish the code to see if Checkbox2 has a tick in it.
So a basic check & a Msgbox pop to be shown saying HI.

Ive run this code many times & just dont see the Hi meessage at all.
The code continues & clears the contents
Why is the code ignoring my If code ???

This is the end of my code.
Everything works fine & does what the code asks its to BUT

    With Sheets("INV")
      Worksheets("INV").Activate
    End With
      
     'ActiveWindow.SelectedSheets.PrintOut copies:=1 'INVOICE NOW PRINTED
      MsgBox "INVOICE HAS NOW BEEN SAVED", vbInformation, "INVOICE PRINT OK MESSAGE"
      
      If CheckBox2 = True Then
      MsgBox "HI"
      End If
    
      Range("L4").Value = Range("L4").Value + 1
      Range("G27:L36").ClearContents
      Range("G39:G40").ClearContents
      Range("G46:G50").ClearContents
      Range("G13").ClearContents
      CheckBox1 = False
      CheckBox2 = False
      Range("G13").Select
      ActiveWorkbook.Save
      

    End Sub

 

[MARK858]

Assuming your code is in a regular sub
If it is a Forms checkbox try

If ActiveSheet.Shapes("CheckBox2").ControlFormat.Value = 1 Then

If it is an ActiveX checkbox try

If ActiveSheet.OLEObjects("CheckBox2").Object.Value = True Then

P.S.
Your With statement here

    With Sheets("INV")
      Worksheets("INV").Activate
    End With

is doing nothing, just use

Worksheets("INV").Activate

 

[ipbr21054]

Hi,
Its active x on a sheet.
I now get the message If without end if.
Where do i put the end if as in various places its ignored or told end if with if

     'ActiveWindow.SelectedSheets.PrintOut copies:=1 'INVOICE NOW PRINTED
      MsgBox "INVOICE HAS NOW BEEN SAVED", vbInformation, "INVOICE PRINT OK MESSAGE"
      
      If ActiveSheet.OLEObjects("CheckBox2").Object.Value = True Then
      Workbooks.Open ("C:\Users\Ian\Desktop\REMOTES ETC\DR\EXCEL WORKSHEETS\MOTORCYCLES.xlsm")
      Worksheets("INVOICES").Activate
      With Sheets("INVOICES")
     .Range("G3").Select
      Call HYPERLINKMC
      
      End With
      Range("L4").Value = Range("L4").Value + 1
      Range("G27:L36").ClearContents
      Range("G39:G40").ClearContents
      Range("G46:G50").ClearContents
      Range("G13").ClearContents
      CheckBox1 = False
      CheckBox2 = False
      Range("G13").Select
      ActiveWorkbook.Save
    
    End Sub

 

[mumps]

According to the way your code is written, put

End If

directly below

ActiveWorkbook.Save

 

[ipbr21054]

Well i did try that but them most of the code in between wasnt actioned.
Whilst waiting for a reply from original post i worked on just getting my code working of which i have now.
So i just need to trigger it to either do what i want or ignore it.

This is why i had the code look to see if Checkbox 2 was True.

Maybe this is another way.
When checkbox 2 is true there is a value in cell G39

Can we have the code look to see if a value is in cell G39 then do what i require.
No value then thats it.

 

[mumps]

If Range("G39") <> "" Then

 

[ipbr21054]

Does this look correct before i make the move to try

Basically if a value is in cell G39 then do RED CODE ONLY

If no value is in cell G39 then do BLUE CODE ONLY

      MsgBox "INVOICE HAS NOW BEEN SAVED", vbInformation, "INVOICE PRINT OK MESSAGE"
      
      If Range("G39") <> "" Then
        
      Workbooks.Open ("C:\Users\Ian\Desktop\REMOTES ETC\DR\EXCEL WORKSHEETS\MOTORCYCLES.xlsm")
      Worksheets("INVOICES").Activate
      With Sheets("INVOICES")
     .Range("G3").Select
      Call HYPERLINKMC
      End With
      Range("L4").Value = Range("L4").Value + 1
      Range("G27:L36").ClearContents
      Range("G39:G40").ClearContents
      Range("G46:G50").ClearContents
      Range("G13").ClearContents
      CheckBox1 = False
      CheckBox2 = False
      Range("D1").Select
      ActiveWorkbook.Save
      
      Else
      
      Range("L4").Value = Range("L4").Value + 1
      Range("G27:L36").ClearContents
      Range("G39:G40").ClearContents
      Range("G46:G50").ClearContents
      Range("G13").ClearContents
      CheckBox1 = False
      CheckBox2 = False
      Range("D1").Select
      ActiveWorkbook.Save
      
    End Sub

 

[mumps]

You forgot the "End If". Try:

Sub Test()
    MsgBox "INVOICE HAS NOW BEEN SAVED", vbInformation, "INVOICE PRINT OK MESSAGE"
    If Range("G39") <> "" Then
         Workbooks.Open ("C:\Users\Ian\Desktop\REMOTES ETC\DR\EXCEL WORKSHEETS\MOTORCYCLES.xlsm")
         Worksheets("INVOICES").Activate
         With Sheets("INVOICES")
        .Range("G3").Select
         Call HYPERLINKMC
         End With
         Range("L4").Value = Range("L4").Value + 1
         Range("G27:L36").ClearContents
         Range("G39:G40").ClearContents
         Range("G46:G50").ClearContents
         Range("G13").ClearContents
         CheckBox1 = False
         CheckBox2 = False
         Range("D1").Select
         ActiveWorkbook.Save
    Else
        Range("L4").Value = Range("L4").Value + 1
        Range("G27:L36").ClearContents
        Range("G39:G40").ClearContents
        Range("G46:G50").ClearContents
        Range("G13").ClearContents
        CheckBox1 = False
        CheckBox2 = False
        Range("D1").Select
        ActiveWorkbook.Save
    End If
End Sub

If you look at my code, you will see that I use indentation to mark the beginning and end of the "If....Then" section of code. I use indentation all the time when writing code because it helps me to see if I have missed an "End If" or if I have missed a "Next" statement in a "For....Next" loop or an "End With" in a "With...End With". I would suggest that you try to use indentation as well to help guide you when writing code.

 

[ipbr21054]

Many thanks.
Note taken & works fine

 

[mumps]

You are very welcome.