code help

[macamarr]

The code below is from someone (SAM) giving me help. I keep getting a Block If without End If when I click on any of my options in the group. What am I missing!!!! Please!!!! Thanks! I've tried removing One of the (end if) at ther end of the code- did not help.




Private Sub FrameDeptSelect_AfterUpdate()

If Me.FrameDeptSelect = 1 Then
Me.Combo10.RowSource = "selectEmployees.EmployeeID, Employees.LastName, Employees.FirstName FROM Employees ORDER BY Employees.LastName; "
Else
If Me.FrameDeptSelect = 2 Then
Me.Combo10.RowSource = "selectEmployees.EmployeeID, Employees.LastName, Employees.FirstName FROM Employees ORDER BY Employees.LastName; "
Else
If Me.FrameDeptSelect = 3 Then
Me.Combo10.RowSource = "selectEmployees.EmployeeID, Employees.LastName, Employees.FirstName FROM Employees ORDER BY Employees.LastName; "
Else
If Me.FrameDeptSelect = 4 Then
Me.Combo10.RowSource = "selectEmployees.EmployeeID, Employees.LastName, Employees.FirstName FROM Employees ORDER BY Employees.LastName; "
Else
If Me.FrameDeptSelect = 5 Then
Me.Combo10.RowSource = "selectEmployees.EmployeeID, Employees.LastName, Employees.FirstName FROM Employees ORDER BY Employees.LastName; "
End If
End If
End Sub

 

[smozgur]

Actually I didn't understand what it is doing since each condition sets same rowsource in your code but correct one :


Private Sub FrameDeptSelect_AfterUpdate()

If Me.FrameDeptSelect = 1 Then
Me.Combo10.RowSource = "selectEmployees.EmployeeID, Employees.LastName, Employees.FirstName FROM Employees ORDER BY Employees.LastName; "
ElseIf Me.FrameDeptSelect = 2 Then
Me.Combo10.RowSource = "selectEmployees.EmployeeID, Employees.LastName, Employees.FirstName FROM Employees ORDER BY Employees.LastName; "
ElseIf Me.FrameDeptSelect = 3 Then
Me.Combo10.RowSource = "selectEmployees.EmployeeID, Employees.LastName, Employees.FirstName FROM Employees ORDER BY Employees.LastName; "
ElseIf Me.FrameDeptSelect = 4 Then
Me.Combo10.RowSource = "selectEmployees.EmployeeID, Employees.LastName, Employees.FirstName FROM Employees ORDER BY Employees.LastName; "
ElseIf Me.FrameDeptSelect = 5 Then
Me.Combo10.RowSource = "selectEmployees.EmployeeID, Employees.LastName, Employees.FirstName FROM Employees ORDER BY Employees.LastName; "
End If

End Sub


General Syntax :

If Condition1 Then
...
ElseIf Condition2 Then
...
...
End If


However I suggest using Select Case (easier to build)

Select Case Me.FrameDeptSelect
Case 1
Me.Combo10.RowSource = "selectEmployees.EmployeeID, Employees.LastName, Employees.FirstName FROM Employees ORDER BY Employees.LastName; "
Case 2
Me.Combo10.RowSource = "selectEmployees.EmployeeID, Employees.LastName, Employees.FirstName FROM Employees ORDER BY Employees.LastName; "
Case 3
Me.Combo10.RowSource = "selectEmployees.EmployeeID, Employees.LastName, Employees.FirstName FROM Employees ORDER BY Employees.LastName; "
Case 4
Me.Combo10.RowSource = "selectEmployees.EmployeeID, Employees.LastName, Employees.FirstName FROM Employees ORDER BY Employees.LastName; "
Case 5
Me.Combo10.RowSource = "selectEmployees.EmployeeID, Employees.LastName, Employees.FirstName FROM Employees ORDER BY Employees.LastName; "
End Select


I hope it helps
Suat