clenaner code to sort

[daveyc18]

hi guys used the recorder for this

finalrow = Cells(Rows.Count, "A").End(xlUp).Row




    ActiveWorkbook.Worksheets("Domestic NI").Sort.SortFields.Clear


    ActiveWorkbook.Worksheets("Domestic NI").Sort.SortFields.Add Key:=Range( _
        "A10:A" & finalrow), SortOn:=xlSortOnValues, Order:=xlDescending, DataOption:= _
        xlSortNormal


        
    ActiveWorkbook.Worksheets("Domestic NI").Sort.SortFields.Add Key:=Range( _
        "R10:R" & finalrow), SortOn:=xlSortOnValues, Order:=xlAscending, DataOption:= _
        xlSortNormal
        
    With ActiveWorkbook.Worksheets("Domestic NI").Sort
        .SetRange Range("A10:T" & finalrow)
        .Header = xlGuess
        .MatchCase = False
        .Orientation = xlTopToBottom
        .SortMethod = xlPinYin
        .Apply
    End With

basically sorting column A from "Z to A" and then adding another sort after ...sorting column "R" from oldest to newest...and I'm highlighting columns A to T first before I use the ribbon to sort.

i'm not confident in cleaning up the code, so would like some help please.

 

[DanteAmor]

And what is the problem?
Is not sorting all the rows correctly?
Maybe it has a filter, then you have to remove the autofilter before you get the last row.

[COLOR=#0000ff]    If Sheets("Domestic NI").AutoFilterMode Then Sheets("Domestic NI").AutoFilterMode = False

[/COLOR]
    finalrow = Cells(Rows.Count, "A").End(xlUp).Row


    ActiveWorkbook.Worksheets("Domestic NI").Sort.SortFields.Clear


    ActiveWorkbook.Worksheets("Domestic NI").Sort.SortFields.Add Key:=Range( _
        "A10:A" & finalrow), SortOn:=xlSortOnValues, Order:=xlDescending, DataOption:= _
        xlSortNormal
        
    ActiveWorkbook.Worksheets("Domestic NI").Sort.SortFields.Add Key:=Range( _
        "R10:R" & finalrow), SortOn:=xlSortOnValues, Order:=xlAscending, DataOption:= _
        xlSortNormal
        
    With ActiveWorkbook.Worksheets("Domestic NI").Sort
        .SetRange Range("A10:T" & finalrow)
        .Header = xlGuess
        .MatchCase = False
        .Orientation = xlTopToBottom
        .SortMethod = xlPinYin
        .Apply
    End With

 

[daveyc18]

there's no problem per se but I just want the "unrecorded " / cleaner /concise version of the code for this type of task

 

[DanteAmor]

Try:

    Set datos = Range("A10:T" & Cells(Rows.Count, "A").End(xlUp).Row)
    datos.Sort key1:=Range("A10"), order1:=xlDescending, key2:=Range("R10"), order2:=xlAscending, Header:=xlNo