clean way to do this ? 3 text box's influencing 4th

[unityjon]

Hi,
i'm slowly getting there after copying loads of examples and working through modify and create my own code to make a userform front end for a database, i'm almost done but looking back through the code some of the parts i have done myself look a little 'messy' but as they are specific to my needs trying to search for 'how to tidy this mess up' is fruitless. the following code takes input from comboboxes adn multiplies the three values together to create a 'score' which we will use elsewhere, i was wondering, seeing as the code is virtually idential could it be done with less code some how ?
Here is the current code:

Private Sub Reg11_Change()

If Reg11.Value >= 0 Then
    Reg14.Value = Reg11.Value * Reg12.Value * Reg13.Value
    End If
End Sub


Private Sub reg12_Change()
If Reg12.Value >= 0 Then
    Reg14.Value = Reg11.Value * Reg12.Value * Reg13.Value
    End If
End Sub

Private Sub Reg13_Change()
If Reg13.Value >= 0 Then
    Reg14.Value = Reg11.Value * Reg12.Value * Reg13.Value
    End If
End Sub

Private Sub Reg14_Change()
    Me.Reg14 = Reg14.Value
    
End Sub

Reg 11, 12, 13 are combobox's
Reg14 is just a textbox to display the result

it would look neater IMO without all the duplication, or am i just being pedantic and if its not broke dont try to fix it ?

 

[ranman256]

I dont see a need for
Private Sub Reg14_Change()
Me.Reg14 = Reg14.Value
End Sub

If you changed Reg14, then it already has a value. No need to set it again.

 

[unityjon]

Good point, i think i put that in for testing so that Reg14 was updated everytime.
I'm looking to see if i can create one if / then statement that captures all of the entries as they happen seeing as i set the values to "0" before hand

 

[FormR]

You could try something like this:

Private Sub Reg11_Change()
If Reg11.Value >= 0 Then Call Calc
End Sub


Private Sub reg12_Change()
If Reg12.Value >= 0 Then Call Calc
End Sub


Private Sub Reg13_Change()
If Reg13.Value >= 0 Then Call Calc
End Sub


Private Sub Calc()
Reg14.Value = Reg11.Value * Reg12.Value * Reg13.Value
End Sub

 

[unityjon]

thats much neater, thank you. Got a few other areas i can apply the same technique too also. Cheers