Check file or folder exists

[tiredofit]

The following code to check if a file or folder exists is taken from here:

https://www.rondebruin.nl/win/s9/win003.htm

This checks for a file:

Sub Test_File_Exist_With_Dir()

    Dim FilePath As String
    Dim TestStr As String

    FilePath = "C:\Users\Ron\test\book1.xlsm"

    TestStr = ""
    On Error Resume Next
    TestStr = Dir(FilePath)
    On Error GoTo 0
    If TestStr = "" Then
        MsgBox "File doesn't exist"
    Else
        MsgBox "File exist"
    End If

End Sub

whereas this checks for a folder:

Sub Test_Folder_Exist_With_Dir()
    Dim FolderPath As String

    FolderPath = "C:\Users\Ron\test"
    If Right(FolderPath, 1) <> "\" Then
        FolderPath = FolderPath & "\"
    End If
    
    If Dir(FolderPath, vbDirectory) <> vbNullString Then
        MsgBox "Folder exist"
    Else
        MsgBox "Folder doesn't exist"
    End If
End Sub

The problem I'm getting is if I pass a string such as:

"C:\Users\Ron\test"

into the Sub Test_File_Exist_With_Dir, it still returns true, even though I've only passed in a folder location and not the name of a file.


How can I amend this?


Thanks

(although using the FSO method does work).

 

[Norie]

I don't think you can really.

When you pass 'C:\Users\Ron\test' to Test_File_Exist_With_Dir how does VBA know that 'test' is a folder and not a file?

 

[tiredofit]

I don't think you can really.

When you pass 'C:\Users\Ron\test' to Test_File_Exist_With_Dir how does VBA know that 'test' is a folder and not a file?

I see, yet using the fso method, it does somehow differentiates between them.

 

[Norie]

How are you checking with FSO?

It has different, specific methods for checking for folders/files.

 

[tiredofit]

How are you checking with FSO?

It has different, specific methods for checking for folders/files.

I passed a folder (as opposed to a file) into the argument:

]
Sub Test_File_Exist_FSO_Late_binding()
'No need to set a reference if you use Late binding
    Dim FSO As Object
    Dim FilePath As String

    Set FSO = CreateObject("scripting.filesystemobject")

    FilePath = "C:\Users\Ron\test\" ' CHANGED IT HERE

    If FSO.FileExists(FilePath) = False Then
        MsgBox "file doesn't exist"
    Else
        MsgBox "File exist"
    End If

End Sub


​

​

 

[shg]

The problem I'm getting is if I pass a string such as "C:\Users\Ron\test" into the Sub Test_File_Exist_With_Dir, it still returns true, even though I've only passed in a folder location and not the name of a file.

Remove the vbDirectory attribute.

 

[tiredofit]

Remove the vbDirectory attribute.

The sub:

Test_File_Exist_With_Dir()

doesn't have a vbDirectory attribute.

 

[shg]

 If Dir(FolderPath[COLOR="#FF0000"], vbDirectory[/COLOR]) <> vbNullString Then

 

[Fluff]

This

"C:\Users\Ron\test"

gives me "File doesn't exist"
but this

"C:\Users\Ron\test[COLOR=#ff0000]\[/COLOR]"

returns "File exist"

 

[tiredofit]

This

"C:\Users\Ron\test"

gives me "File doesn't exist"
but this

"C:\Users\Ron\test[COLOR=#ff0000]\[/COLOR]"

returns "File exist"

I see, thanks.