Change Event - Textbox = > < Zero

[03856me]

I have the following code setup in a change event which works perfectly unless the user enters any number preceeded by a zero, like 02 03 etc., then it fires the <= code which isn't correct. Is there some code I can add that would prevent this? I even tried it in the exit event but it worked the same.

There are 3 possible entries that are acceptable
0 should fire first code
-# should fire first code
1-99 should fire second code

Maybe there's a better way to go about this? I am open to any suggestions

Private Sub txt_dbh_Change()
'check the value is negative or equal to zero
  If Me.txt_dbh.Value <= 0 Then
     Me.txt_height.Visible = False
     Me.lbl_height.Visible = False
     Me.lbl_heightNote.Visible = False
     Me.txt_1log.Visible = False
     Me.lbl_1log.Visible = False
     Me.cmd_add.Visible = False
     Me.cmd_addNegative.Visible = True
     Cancel = True
'check the value is > 0
Else
  If Me.txt_dbh.Value > 0 Then
     Me.txt_height.Visible = True
     Me.lbl_height.Visible = True
     Me.lbl_heightNote.Visible = True
     Me.txt_1log.Visible = True
     Me.lbl_1log.Visible = True
     Cancel = True
   End If
  End If
End Sub

 

[p45cal]

a quick fix might be instead of:
If Me.txt_dbh.Value
have:
If val(Me.txt_dbh.Value)

 

[erik.van.geit]

Hi,

Your code is not logic to my sense.

When you write "23" for instance, the code would fire twice.
When you want to input "-1", you would first get the ">0" code when writing the minus sign.
If only numbers are to be put there, you migh consider a listbox with those numbers.
Another possibility would be to ask for a number, then click a button which would check if it's really a number and then fire the code.

The line "cancel = true" makes no sense. It belongs to another kind of event like "sheet rightclick".

kind regards,
Erik

 

[03856me]

Thanks p45cal, that worked exactly as I wanted.....

 

[mikerickson]

Perhaps you could use the AfterUpdate event or the BeforeUpdate event instead of Change.