Cell with incorrect value

KhallP

Board Regular
Joined
Mar 30, 2021
Messages
157
Office Version
  1. 2016
Platform
  1. Windows
I created a procedure that writes a specific text in the cell is empty, but when this occurs the value entered is always "TRUE" can someone help?



VBA Code:
Public Sub WriteValues()
    
    Ws = ActiveWorkbook.Sheets.Count
    
    For counter = 1 To Ws
    
        Worksheets(counter).Select
        
        ActiveCell = Range("AC12").Select
 
        If ActiveCell.Value = "" Then
        
        ActiveCell.Value = "Date"
        ActiveCell.HorizontalAlignment = xlRight
 
        ActiveCell.Offset(0, 1).Select
        
        ActiveCell.Value = "Time"
        ActiveCell.HorizontalAlignment = xlRight
 
        ActiveCell.Offset(0, 1).Select
        
        ActiveCell.Value = "Value"
        ActiveCell.HorizontalAlignment = xlRight
 
        Else
        End If

        Range("AC13").Select

        If ActiveCell.Value = "" Then
            Call FillCells
 
        Else
        End If
    
    Next
    
End Sub
 

Excel Facts

Remove leading & trailing spaces
Save as CSV to remove all leading and trailing spaces. It is faster than using TRIM().
Please try this, your code is too complex, try to be simple.
VBA Code:
Public Sub WriteValues()

    Dim ws As Worksheet

    For Each ws In Worksheets
        With ws.Range("AC12:AE12")
            .Value = Array("Date", "Time", "Value")
            .HorizontalAlignment = xlRight
        End With

        If ws.Range("AC13") = "" Then
             ' Here is your customized function.
             Call FillCells
        End If

    Next

End Sub
 
Upvote 0
Hi KhaliP,

the code you supplied is static and will always check the very same cells, so the result you get isn´t really surprising me.

Ciao,
Holger
 
Upvote 0

Forum statistics

Threads
1,223,901
Messages
6,175,277
Members
452,629
Latest member
SahilPolekar

We've detected that you are using an adblocker.

We have a great community of people providing Excel help here, but the hosting costs are enormous. You can help keep this site running by allowing ads on MrExcel.com.
Allow Ads at MrExcel

Which adblocker are you using?

Disable AdBlock

Follow these easy steps to disable AdBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the icon in the browser’s toolbar.
2)Click on the "Pause on this site" option.
Go back

Disable AdBlock Plus

Follow these easy steps to disable AdBlock Plus

1)Click on the icon in the browser’s toolbar.
2)Click on the toggle to disable it for "mrexcel.com".
Go back

Disable uBlock Origin

Follow these easy steps to disable uBlock Origin

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back

Disable uBlock

Follow these easy steps to disable uBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back
Back
Top