Can I combine these small macros into one big macro?

surfdoc37

New Member
Joined
Mar 12, 2004
Messages
23
Office Version
  1. 2019
  2. 2013
Platform
  1. Windows
  2. MacOS
Hello and apologies for maybe not having the clearest formatting here. I would like to combine several small macros, which sort out some rows from a sheet, copy them, and paste them into a new blank sheet. Because I am lazy I would like to use one macro to perform the task instead of using the six small macros which do work just fine individually. Macros are all basically the same, only the sort criteria changes. In the VBA editor they are separated by a horizontal line if that matters.

_______________________________________________________

Sub make_C_sheet()
'
' make_C_sheet Macro
'

'
Selection.AutoFilter
ActiveSheet.Range("$A$1:$AG$653").AutoFilter Field:=3, Criteria1:="=*C*", _
Operator:=xlAnd
Cells.Select
Selection.Copy
Sheets.Add After:=ActiveSheet
Range("A1").Select
ActiveSheet.Paste
Columns("A:A").ColumnWidth = 18
Range("A1").Select
End Sub
Sub make_1B_sheet()
'
' make_1B_sheet Macro
'

'
Selection.AutoFilter
ActiveSheet.Range("$A$1:$AG$653").AutoFilter Field:=3, Criteria1:="=*1B*", _
Operator:=xlAnd
Cells.Select
Selection.Copy
Sheets.Add After:=ActiveSheet
Range("A1").Select
ActiveSheet.Paste
Columns("A:A").ColumnWidth = 18
Range("A1").Select
End Sub
Sub make_2B_sheet()
'
' make_2B_sheet Macro
'

'
Selection.AutoFilter
ActiveSheet.Range("$A$1:$AG$653").AutoFilter Field:=3, Criteria1:="=*2B*", _
Operator:=xlAnd
Cells.Select
Selection.Copy
Sheets.Add After:=ActiveSheet
Range("A1").Select
ActiveSheet.Paste
Columns("A:A").ColumnWidth = 18
Range("A1").Select
End Sub

Sub make_SS_sheet()
'
' make_SS_sheet Macro
'

'
Selection.AutoFilter
ActiveSheet.Range("$A$1:$AG$653").AutoFilter Field:=3, Criteria1:="=*SS*", _
Operator:=xlAnd
Cells.Select
Selection.Copy
Sheets.Add After:=ActiveSheet
Range("A1").Select
ActiveSheet.Paste
Columns("A:A").ColumnWidth = 18
Range("A1").Select
End Sub
Sub make_3B_sheet()
'
' make_3B_sheet Macro
'

'
Selection.AutoFilter
ActiveSheet.Range("$A$1:$AG$653").AutoFilter Field:=3, Criteria1:="=*3B*", _
Operator:=xlAnd
Cells.Select
Selection.Copy
Sheets.Add After:=ActiveSheet
Range("A1").Select
ActiveSheet.Paste
Columns("A:A").ColumnWidth = 18
Range("A1").Select
End Sub
Sub make_OF_sheet()
'
' make_OF_sheet Macro
'

'
Selection.AutoFilter
ActiveSheet.Range("$A$1:$AG$653").AutoFilter Field:=3, Criteria1:="=*OF*", _
Operator:=xlAnd
Cells.Select
Selection.Copy
Sheets.Add After:=ActiveSheet
Range("A1").Select
ActiveSheet.Paste
Columns("A:A").ColumnWidth = 18
Range("A1").Select
End Sub


_______________________________________________________

I searched and found the following which looks like it might be a macro to run sequential macros. But not sure how to adapt it, or, whether that is better than just having one great big macro.


_______________________________________________________


Sub Run_A_Procedures()
Call ModuleName.ProcedureName
Call ModuleName.A_1001_Prepare_Sheet
Call ModuleName.A_1002_MergeMultipleWorkbooks
Call ModuleName.A_1003_DeleteSheets1
Call ModuleName.A_1004_Rename_Sheet_after_Workbook_Name
End Sub

__________________________________________________________________


Appreciate any assistance!
 

Excel Facts

Create a chart in one keystroke
Select the data and press Alt+F1 to insert a default chart. You can change the default chart to any chart type
Try something like:

Call make_C_sheet
Call make_1B_sheet
Call make_2B_sheet
'etc,
 
Upvote 0
See if this does what you are after.

VBA Code:
Sub Combined()

    Dim arrCriteria As Variant
    Dim shtMain As Worksheet, shtNew As Worksheet
    Dim rngMain As Range
    Dim lrMain As Long, i As Long
    
    arrCriteria = Array("*C*", "*1B*", "*2B*", "*SS*", "*3B*", "*OF*")
    
    Set shtMain = ActiveSheet
    With shtMain
        lrMain = .Range("A" & Rows.Count).End(xlUp).Row             ' set last row dynamically
        Set rngMain = .Range("A1:AG" & lrMain)
        If .FilterMode Then .ShowAllData                            ' clear any existing filters
    End With
     
    For i = 0 To UBound(arrCriteria)
        rngMain.AutoFilter Field:=3, Criteria1:="=" & arrCriteria(i)
        rngMain.Copy
        
        Sheets.Add After:=ActiveSheet
        Set shtNew = ActiveSheet
        With shtNew
            .Range("A1").PasteSpecial Paste:=xlPasteAll
            .Columns("A:A").ColumnWidth = 18
            .Range("A1").Select
        End With
    Next i
    
    rngMain.AutoFilter Field:=3                                     ' Clear last filter used
                
End Sub
 
Upvote 0
Try something like:

Call make_C_sheet
Call make_1B_sheet
Call make_2B_sheet
'etc,
Unsuccessfully attempted:

Sub combo_macro()

Call make_C_sheet
Call make_1B_sheet
Call make_2B_sheet
Call make_SS_sheet
Call make_3B_sheet
Call make_OF_sheet

End Sub


Got: "Compile error: Sub or Function not defined"
 
Upvote 0
Do you have those subroutines in a different module?
 
Upvote 0

Forum statistics

Threads
1,223,908
Messages
6,175,306
Members
452,633
Latest member
DougMo

We've detected that you are using an adblocker.

We have a great community of people providing Excel help here, but the hosting costs are enormous. You can help keep this site running by allowing ads on MrExcel.com.
Allow Ads at MrExcel

Which adblocker are you using?

Disable AdBlock

Follow these easy steps to disable AdBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the icon in the browser’s toolbar.
2)Click on the "Pause on this site" option.
Go back

Disable AdBlock Plus

Follow these easy steps to disable AdBlock Plus

1)Click on the icon in the browser’s toolbar.
2)Click on the toggle to disable it for "mrexcel.com".
Go back

Disable uBlock Origin

Follow these easy steps to disable uBlock Origin

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back

Disable uBlock

Follow these easy steps to disable uBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back
Back
Top