Beforeclose not working

[S Oberlander]

I have the below on my personal macro workbook to save a backup (I nearly lost it one time too many);
but its not getting called:

Private Sub Workbook_BeforeClose(Cancel As Boolean)
ActiveWorkbook.SaveAs "https://smpl-my.sharepoint.com/personal/myuser_com/Documents/Desktop/Personal backup.xlsb", FileFormat:=50, CreateBackup:=False
End Sub

 

[MARK858]

When is your Personal workbook the Activeworkbook? you probably mean ThisWorkbook, if you have the code in the Personal workbook.

The easiest way to test if it is being called is to place a message box as the first line in the code.

 

[S Oberlander]

You're right, but I never got to that part, it never got into the sub

 

[MARK858]

I've just tried it and it appears Excel closes the application rather than the specific workbook and so the code won't fire.

P.S. I also had to end Excel as a task in Task manager to open it again

 

[MARK858]

I haven't tried it but have a look at the link below

Is there any way to trigger event before excel application close?

I know the event before workbook close but this won't work if I close the whole application (eg: via press "Alt+F4" on windows). How can I trigger event before application close? Option Explicit Private Sub Workbook_BeforeClose(Cancel As Boolean) Const sBak As String =...

www.mrexcel.com

 

[S Oberlander]

Cool!
And now I'm wondering why it didn't occur to me previously to add a timestamp to the backup being saved instead of overwriting the old backup.