Array Overflow Errow

[VBA_Cancer]

Sub Searching()
Dim FilePath As String
Dim strFilename As String: strFilename = "C:\Users\Jack\Desktop\test.txt"
Dim strTextLine As String
Dim iFile As Integer: iFile = FreeFile
Dim income_a(10) As Integer, i As Integer
i = 0
Open strFilename For Input As [URL=https://www.mrexcel.com/forum/usertag.php?do=list&action=hash&hash=iFile]#iFile[/URL] 
Do Until EOF(1)
    Line Input [URL=https://www.mrexcel.com/forum/usertag.php?do=list&action=hash&hash=1]#1[/URL] , strTextLine
    If Split(strTextLine, ",")(0) = searchtxt.Value Then
        If IsNumeric(Split(strTextLine, ",")(1)) Then
        income_a(i) = CInt(Split(strTextLine, ",")(1))
        i = i + 1
        End If
    End If
Loop
allp.Value = WorksheetFunction.Sum(income_a)
Close [URL=https://www.mrexcel.com/forum/usertag.php?do=list&action=hash&hash=iFile]#iFile[/URL]

The complete file that is being open is this:

ABC123,30000,25,15
ABC123,50000,x,...
ABC123,45000,22,32
ABC123,...,23,14

I been trying to fetch all of the integers in the 2nd position of each line and store them in an array. This keeps giving me an overflow error and I don't know why!

 

[gallen]

Without looking too much, you get that when you have infinite loops.

I'm guessing you need an i instead of a 1:

[COLOR=#333333]Do Until EOF([/COLOR][COLOR=#ff0000][B]i[/B][/COLOR][COLOR=#333333])[/COLOR]

 

[VBA_Cancer]

Without looking too much, you get that when you have infinite loops.

I'm guessing you need an i instead of a 1:

[COLOR=#333333]Do Until EOF([/COLOR][COLOR=#ff0000][B]i[/B][/COLOR][COLOR=#333333])[/COLOR]

when I change it to i, it gives me "bad file name or number" error. Also I thought this is not an infinite loops as it goes through all of the lines?

I am pretty new to excel vba, this is what I understand from what I found on the internet.

 

[gallen]

Ignore me I should have spotted it was End Of File. I'll have a closer look...

 

[gallen]

Tested your code and it does indeed go through each line of the file.

On Which line does the error occur?

 

[FormR]

This keeps giving me an overflow error and I don't know why!

Hi, welcome to the forum.

Integers can only store numbers up to 32,767 - from your sample file it seems you are trying to store numbers larger than that.

Try changing this line to:

Dim income_a(10) As Long, i As Integer

And this line to:

income_a(i) = CLng(Split(strTextLine, ",")(1))

 

[gallen]

Hi, welcome to the forum.

Integers can only store numbers up to 32,767 - from your sample file it seems you are trying to store numbers larger than that.

Try changing this line to:

Dim income_a(10) As Long, i As Integer

And this line to:

income_a(i) = CLng(Split(strTextLine, ",")(1))

Schoolboy error. Missed that

 

[VBA_Cancer]

Hi, welcome to the forum.

Integers can only store numbers up to 32,767 - from your sample file it seems you are trying to store numbers larger than that.

Try changing this line to:

Dim income_a(10) As Long, i As Integer

And this line to:

income_a(i) = CLng(Split(strTextLine, ",")(1))

Thank you! I been spoiled by Python arrays which takes in anything!

 

[FormR]

Thank you! I been spoiled by Python arrays which takes in anything!

Hi, happy to help

Not suggesting that you should, but you could have declared your array as Variant which would pretty much take anything.