Advice for sort range on worksheet

[ipbr21054]

Morning,
Im using the code shown below but when i press the command button nothing happens at all.
Do you see an issue.

Thanks

Worksheet called NAMES
Table name is Table4
Headers in row 1
Currently Range is A2:E43
Sort A-Z in column A

Private Sub CommandButton1_Click()
Dim x As Long
Dim ws As Worksheet
Set ws = Sheets("NAMES")
Dim SortColumn As String

If Len(SortColumn) <> 0 Then
Application.ScreenUpdating = False
With ws
If .AutoFilterMode Then .AutoFilterMode = False
x = .Cells(.Rows.Count, 1).End(xlUp).Row
.Range("A2:E" & x).Sort Key1:=.Cells(2, SortColumn), Order1:=xlAscending, Header:=xlGuess
End With
End If
End Sub

 

[Joe4]

You are checking the length of a variables names "SortColumn" here:

If Len(SortColumn) <> 0 Then

but you haven't set that variable equal to anything, so it will ALWAYS be 0, meaning that that IF statement will never be satisfied.

 

[ipbr21054]

Im sorry but i was lost with that one so did what i thought was easier with less code BUT ha ha ha

This works in respect or sorting etc but where i have headers in row 1 & the list starts in row 2 after the code is run i see some headers replaced by Column 1 Column 2 & also the first customers name in cell A1

I thought that as my range was A2:E43 that is what it would sort.
I assume headers has something to do with it but what ?

Private Sub CommandButton1_Click()

Dim ws As Worksheet
Dim Rng As Range
Set ws = Worksheets("NAMES")
Set Rng = ws.Range("A2:E43")
Rng.Sort Key1:=Range("A:A"), Order1:=xlAscending

End Sub

 

[Joe4]

How about this?

Private Sub CommandButton1_Click()

Dim ws As Worksheet
Dim Rng As Range
Set ws = Worksheets("NAMES")
Set Rng = ws.Range("A1:E43")
Rng.Sort Key1:=Range("A1"), Order1:=xlAscending, Header:=xlYes

End Sub

 

[ipbr21054]

Thanks all done,

I seen what you did there

 

[Joe4]

You are welcome.