ADO WHERE question

[BarryL]

Hi All,

Trying to learn about ADO to fix my big file issues seeing as work wont let me use an SQL DB , R or Python. Can anyone tell me whats wrong with the below WHERE condition? I'm debugging at mrs.Open with an error of "Parameters expected 1"

Conn.Open sconnect
sSQLSting = "SELECT * From [Sheet1$A1:Z2000] WHERE MASTER_PORTFOLIO_CODE = " & "XXXXX"
Debug.Print sSQLSting
mrs.Open sSQLSting, Conn

cheers

 

[RoryA]

Text values need to be enclosed in apostrophes like this:

sSQLSting = "SELECT * From [Sheet1$A1:Z2000] WHERE MASTER_PORTFOLIO_CODE = 'XXXXX'"

 

[BarryL]

Yep, thats it. Cheers Rory.

One more question if I may, If I was working with a sheet that didnt have a table inserted how would I query that? as in trying

"SELECT * From [Sheet1$A1:Z2000] WHERE [Sheet1$A1:A2000] = 'XXXX'"

doesnt work.

 

[RoryA]

Having a table or not is actually irrelevant - ADO has no concept of them. As long as the column header is the same, and you specified that there are column headers in your connection string, the code will work as it was before.

 

[BarryL]

below is what im working with but it doesnt seem to work with specifying the columns

Sub sbADOExample()
Dim sSQLQry As String
Dim ReturnArray
Dim Conn As New ADODB.Connection
Dim mrs As New ADODB.Recordset
Dim DBPath As String, sconnect As String
DBPath = "zzzz.xls"
sconnect = "Provider=MSDASQL.1;DSN=Excel Files;DBQ=" & DBPath & ";HDR=NO';"
Conn.Open sconnect
sSQLSting = "SELECT * From [Sheet1$A1:Z20000] WHERE [Sheet1$A1:A20000] = 'XXXX'"
Debug.Print sSQLSting
mrs.Open sSQLSting, Conn
Sheet1.Range("A2").CopyFromRecordset mrs
mrs.Close
Conn.Close
End Sub

 

[RoryA]

Since you've specified that you don't have headers (which is a little odd in a worksheet), you have to use F1, F2 etc as the column names, so it would be

WHERE [F2] = 'XXXX'

for the criterion part.