Help with vbs to loop thu folders

[Jon von der Heyden]

Hi

I realise that this isn't strictly Excel, but I have seen vbs been used before so I'm hoping someone can assist. I have a problem with following code... It loops thru all subfolders correctly but I want to return the properties of the files housed within the folders.

Set objFSO = CreateObject("Scripting.FileSystemObject")

Set objLogFile = objFSO.CreateTextFile("C:\ScriptLog.txt")

LoopSubFolders objFSO.GetFolder("H:\")

Sub LoopSubFolders(Folder)

	For Each SubFolder in Folder.SubFolders
		LoopSubFolders SubFolder

			If SubFolder.Size > 10240 Then
				For Each objFile in Folder.SubFolders
					objLogFile.WriteLine objFile.Type
				Next
			End If

	Next

End Sub

I think the problem is here:

For Each objFile in Folder.SubFolders

I have noticed that this still only looks at File Folders and not the actuals files (e.g. .xls, .pdf etc.)

Any help?

Thanks
Jon

 

[Richard Schollar]

Hello Jon

Don't you need to access an actual Files collection? I have bugger all familiarity with VBS so could be way wrong here but I would have thought the following may improve things:

Set objFSO = CreateObject("Scripting.FileSystemObject") 

Set objLogFile = objFSO.CreateTextFile("C:\ScriptLog.txt") 

LoopSubFolders objFSO.GetFolder("H:\") 

Sub LoopSubFolders(Folder) 

   For Each SubFolder in Folder.SubFolders 
      LoopSubFolders SubFolder 

         If SubFolder.Size > 10240 Then 
            For Each objFile in Folder.SubFolders.Files
               objLogFile.WriteLine objFile.Type 
            Next 
         End If 

   Next 

End Sub

 

[Norie]

Jon

That isn't really VBS, it's VBA using the FileSystemObject.

Like Richard I'm not too familiar with this sort of thing, perhaps a tutorial like this might help you.

 

[Jon von der Heyden]

That isn't really VBS, it's VBA using the FileSystemObject.

It's written in notepad and saved as .vbs. I've got scriptcentre installed and I've been referencing that for the code. I'm almost there.

Norie, thanks for the tutorial, I'm going to have a browse thru it.

Rich, I tried that but it bugs out on .Files... Darn it!!!

Thanks guys...

 

[Jon von der Heyden]

Ooooooooooh Rich, you were so nearly there mate.

For Each objFile in SubFolder.Files

This works! Thanks for the suggestion, it got me there! Next shout is on me!


Norie, thanks for this . It's wicked!!! Given me nice grounding for use in VBA...

 

[Norie]

Jon

No problem.

I honestly did think that was VBA you'd posted.

It's been a long time since I scripted in VBS.

And that was just simple stuff like message boxes and arrays to assist with data input.